Skip to content

chore: use clean to remove dist-* folders #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 10, 2022

Issue #, if available:
Internal discussions on Slack.

Reasons for update:

  • We don't use clean:docs command in clients in aws-sdk-js-v3 repo.
  • We do not have any clean commands in non-clients.
  • The docs may have been created in a different folder.

Ideally, the typedoc script should clean the folder used for docs be default, or provide an option or plugin to perform that function (like webpack does). Follow-up feature request created at aws/aws-sdk-js-v3#3167

Description of changes:
Use clean to remove dist-* folders

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 10, 2022 14:43
@trivikr trivikr changed the title chore: use clean to remove dist-* folders chore(clients): use clean to remove dist-* folders Jan 10, 2022
@trivikr trivikr changed the title chore(clients): use clean to remove dist-* folders chore: use clean to remove dist-* folders Jan 10, 2022
@trivikr trivikr merged commit 0ee77af into smithy-lang:main Jan 10, 2022
@trivikr trivikr deleted the update-clean-command branch January 10, 2022 18:08
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants