escape multi-line comment close tag #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Jan 6, 2020
trivikr
approved these changes
Jan 6, 2020
|
@trivikr, the Java needs its own escape. The generated comment ends up as |
Confirmed that |
added in ac7e28d. |
kstich
approved these changes
Jan 7, 2020
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
…ersion is used (#77) * Standardize usage of TSLib across all packages, and ensure a single version is used * Ensure noEmitHelpers is also set in each tsconfig file * Include TSLib as a dependency in all new modules and ensure importHelpers and noEmitHelpers are enabled by default
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
…ersion is used (#77) * Standardize usage of TSLib across all packages, and ensure a single version is used * Ensure noEmitHelpers is also set in each tsconfig file * Include TSLib as a dependency in all new modules and ensure importHelpers and noEmitHelpers are enabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes doc strings containing
*/causing mult-line comments to be closed prematurely.Fixes #74
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.