Skip to content

Commit 58e4e28

Browse files
dariuszkucsmyrick
authored and
smyrick
committed
Explicitly disable nexus-staging-maven-plugin in example app (ExpediaGroup#269)
Additional configuration fixes: * remove maven-javadoc-plugin as dokka already genertes the javadoc jar * explicitly disable maven-deploy-plugin as we are using nexus-staging-maven-plugin with explicit config * skip generating sources for the example app
1 parent c62f209 commit 58e4e28

File tree

2 files changed

+19
-32
lines changed

2 files changed

+19
-32
lines changed

graphql-kotlin-spring-example/pom.xml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
<properties>
1818
<spring-boot.version>2.1.2.RELEASE</spring-boot.version>
19+
20+
<!-- skip release plugins -->
21+
<maven.source.skip>true</maven.source.skip>
1922
</properties>
2023

2124
<dependencies>
@@ -73,22 +76,27 @@
7376
<!-- <groupId>org.apache.maven.plugins</groupId>-->
7477
<!-- <artifactId>maven-antrun-plugin</artifactId>-->
7578
<!-- </plugin>-->
76-
<plugin>
77-
<groupId>org.apache.maven.plugins</groupId>
78-
<artifactId>maven-deploy-plugin</artifactId>
79-
<configuration>
80-
<!-- don't publish this artifact -->
81-
<skip>true</skip>
82-
</configuration>
83-
</plugin>
8479
<plugin>
8580
<groupId>org.jetbrains.dokka</groupId>
8681
<artifactId>dokka-maven-plugin</artifactId>
82+
<version>${dokka-maven-plugin.version}</version>
8783
<configuration>
8884
<!-- don't generate javadocs as there is no artifact-->
8985
<skip>true</skip>
9086
</configuration>
9187
</plugin>
88+
<plugin>
89+
<groupId>org.sonatype.plugins</groupId>
90+
<artifactId>nexus-staging-maven-plugin</artifactId>
91+
<version>1.6.8</version>
92+
<extensions>true</extensions>
93+
<executions>
94+
<execution>
95+
<id>default-deploy</id>
96+
<phase>none</phase>
97+
</execution>
98+
</executions>
99+
</plugin>
92100
</plugins>
93101
</build>
94102
</project>

pom.xml

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@
9595
<detekt-cli.version>1.0.0-RC14</detekt-cli.version>
9696
<ktlint.version>0.30.0</ktlint.version>
9797
<jacoco-maven-plugin.version>0.8.3</jacoco-maven-plugin.version>
98+
99+
<!-- disable default maven-deploy-plugin in favor of nexus-staging-maven-plugin -->
100+
<maven.deploy.skip>true</maven.deploy.skip>
98101
</properties>
99102

100103
<pluginRepositories>
@@ -342,11 +345,6 @@
342345
</property>
343346
</activation>
344347

345-
<!-- Exclude the example app from releases -->
346-
<modules>
347-
<module>graphql-kotlin-schema-generator</module>
348-
</modules>
349-
350348
<build>
351349
<plugins>
352350
<!-- Release to Maven central -->
@@ -384,20 +382,6 @@
384382
</execution>
385383
</executions>
386384
</plugin>
387-
<!-- Attach javadocs to jar -->
388-
<plugin>
389-
<groupId>org.apache.maven.plugins</groupId>
390-
<artifactId>maven-javadoc-plugin</artifactId>
391-
<version>3.0.1</version>
392-
<executions>
393-
<execution>
394-
<id>attach-javadocs</id>
395-
<goals>
396-
<goal>jar</goal>
397-
</goals>
398-
</execution>
399-
</executions>
400-
</plugin>
401385
<!-- Sign the artifacts -->
402386
<plugin>
403387
<groupId>org.apache.maven.plugins</groupId>
@@ -422,11 +406,6 @@
422406
<jdk>1.8</jdk>
423407
</activation>
424408

425-
<!-- Exclude the example app from javadoc packages -->
426-
<modules>
427-
<module>graphql-kotlin-schema-generator</module>
428-
</modules>
429-
430409
<build>
431410
<plugins>
432411
<plugin>

0 commit comments

Comments
 (0)