Skip to content

Allow Async::HTTP::Internet methods to accept URI::HTTP objects. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2024
Merged

Allow Async::HTTP::Internet methods to accept URI::HTTP objects. #118

merged 1 commit into from
Jun 23, 2024

Conversation

postmodern
Copy link
Contributor

URI::HTTP objects do not define a to_str method, so call to_s on the uri instead.

Types of Changes

  • Bug fix.

Contribution

@ioquatix
Copy link
Member

This seems reasonable to me, but I just wonder why it was to_str in the first place.

@ioquatix ioquatix self-assigned this Jun 23, 2024
@postmodern @ioquatix
Allow Async::HTTP::Internet methods to accept URI::HTTP objects.
3282511 
* `URI::HTTP` objects do not define a `to_str` method, so use `to_s` instead.
@ioquatix ioquatix merged commit 0f11811 into socketry:main Jun 23, 2024
15 of 18 checks passed
@ioquatix
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees

@ioquatix ioquatix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postmodern @ioquatix