Better handling of url userinfo.

Author: ioquatix

lib/async/redis/endpoint.rb

@@ -161,7 +161,17 @@ def database
 			end
 
 			def credentials
-				@options[:credentials] || @url.userinfo&.split(":")
+				@options[:credentials] || extract_userinfo(@url.userinfo)
+			end
+			
+			private def extract_userinfo(userinfo)
+				if userinfo
+					credentials = userinfo.split(":").reject(&:empty?)
+					
+					if credentials.any?
+						return credentials
+					end
+				end
 			end
 
 			def localhost?

test/async/redis/endpoint.rb

@@ -12,6 +12,23 @@
 
 	let(:endpoint) {Async::Redis.local_endpoint}
 
+	with '#credentials' do
+		it "can parse a url with username and password" do
+			endpoint = Async::Redis::Endpoint.parse("redis://testuser:testpassword@localhost")
+			expect(endpoint.credentials).to be == ["testuser", "testpassword"]
+		end
+		
+		it "can parse a url with a blank username and password" do
+			endpoint = Async::Redis::Endpoint.parse("redis://:testpassword@localhost")
+			expect(endpoint.credentials).to be == ["testpassword"]
+		end
+		
+		it "can parse a url with a password only" do
+			endpoint = Async::Redis::Endpoint.parse("redis://testpassword@localhost")
+			expect(endpoint.credentials).to be == ["testpassword"]
+		end
+	end
+	
 	with '#protocol' do
 		it "defaults to RESP2" do
 			expect(endpoint.protocol).to be == Async::Redis::Protocol::RESP2