gitserver: Rename RepoUpdate to FetchRepository (#61865)

Just a simple name change to reflect the gRPC API surface in the service layer.

Test plan:

CI and go compiler

Author: eseliger

cmd/gitserver/internal/BUILD.bazel

@@ -129,7 +129,6 @@ go_test(
         "//internal/limiter",
         "//internal/observation",
         "//internal/ratelimit",
-        "//internal/trace",
         "//internal/types",
         "//internal/vcs",
         "//internal/wrexec",

cmd/gitserver/internal/ensurerevision.go

@@ -32,7 +32,7 @@ func (s *Server) EnsureRevision(ctx context.Context, repo api.RepoName, rev stri
 	}
 
 	// Revision not found, update before returning.
-	_, _, err := s.RepoUpdate(ctx, repo)
+	_, _, err := s.FetchRepository(ctx, repo)
 	if err != nil {
 		if ctx.Err() == nil {
 			ensureRevisionCounter.WithLabelValues("update_failed").Inc()

cmd/gitserver/internal/integration_tests/clone_test.go

@@ -91,7 +91,7 @@ func TestClone(t *testing.T) {
 
 	// Requesting a repo update should figure out that the repo is not yet
 	// cloned and call clone. We expect that clone to succeed.
-	_, _, err := s.RepoUpdate(ctx, repo)
+	_, _, err := s.FetchRepository(ctx, repo)
 	require.NoError(t, err)
 
 	// Should have acquired a lock.
@@ -194,7 +194,7 @@ func TestClone_Fail(t *testing.T) {
 	// Requesting a repo update should figure out that the repo is not yet
 	// cloned and call clone. We expect that clone to fail, because vcssyncer.IsCloneable
 	// fails here.
-	_, _, err := s.RepoUpdate(ctx, repo)
+	_, _, err := s.FetchRepository(ctx, repo)
 	require.Error(t, err)
 	// Note that this error is from IsCloneable(), not from Clone().
 	require.Contains(t, err.Error(), "error cloning repo: repo github.com/test/repo not cloneable:")
@@ -232,7 +232,7 @@ func TestClone_Fail(t *testing.T) {
 	// Requesting another repo update should figure out that the repo is not yet
 	// cloned and call clone. We expect that clone to fail, but in the vcssyncer.Clone
 	// stage this time, not vcssyncer.IsCloneable.
-	_, _, err = s.RepoUpdate(ctx, repo)
+	_, _, err = s.FetchRepository(ctx, repo)
 	require.Error(t, err)
 	require.Contains(t, err.Error(), "failed to clone github.com/test/repo: clone failed. Output: Creating bare repo\nCreated bare repo at")
 

cmd/gitserver/internal/integration_tests/resolverevisions_test.go

@@ -126,7 +126,7 @@ func TestClient_ResolveRevision(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run("", func(t *testing.T) {
-			_, _, err := s.RepoUpdate(ctx, api.RepoName(remote))
+			_, _, err := s.FetchRepository(ctx, api.RepoName(remote))
 			require.NoError(t, err)
 
 			got, err := cli.ResolveRevision(ctx, api.RepoName(remote), test.input, gitserver.ResolveRevisionOptions{EnsureRevision: false})

cmd/gitserver/internal/integration_tests/utils_test.go

@@ -145,7 +145,7 @@ func MakeGitRepository(t testing.TB, cmds ...string) api.RepoName {
 	t.Helper()
 	dir := InitGitRepository(t, cmds...)
 	repo := api.RepoName(filepath.Base(dir))
-	_, _, err := testServer.RepoUpdate(context.Background(), repo)
+	_, _, err := testServer.FetchRepository(context.Background(), repo)
 	require.NoError(t, err)
 	return repo
 }