Skip to content
This repository was archived by the owner on Apr 17, 2022. It is now read-only.

Commit 5d84b4d

Browse files
committed
Fix #19: Key function this signature fixed.
1 parent 41718db commit 5d84b4d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/scala/org/singlespaced/d3js/selection.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ trait BaseSelection[Datum, T <: BaseSelection[Datum,T]] extends BaseDom[Datum,T]
7070

7171
def data(): js.Array[Datum] = js.native
7272
def data[NewDatum](data: js.Array[NewDatum]): Update[NewDatum] = js.native
73-
def data[NewDatum](data: js.Array[NewDatum], key: js.ThisFunction2[Datum|NewDatum,js.UndefOr[NewDatum], Int, String]): Update[NewDatum] = js.native
73+
def data[NewDatum](data: js.Array[NewDatum], key: js.ThisFunction2[dom.Node|js.Array[NewDatum],js.UndefOr[NewDatum], Int, String]): Update[NewDatum] = js.native
7474
def data[NewDatum <: Datum](data: js.Array[NewDatum], key: js.Function2[Datum, Int, String]): Update[NewDatum] = js.native
7575
def data[NewDatum](data: DatumFunction[js.Array[NewDatum]]): Update[NewDatum] = js.native
76-
def data[NewDatum](data: DatumFunction[js.Array[NewDatum]], key: js.ThisFunction2[Datum|NewDatum,js.UndefOr[NewDatum], Int, String]): Update[NewDatum] = js.native
76+
def data[NewDatum](data: DatumFunction[js.Array[NewDatum]], key: js.ThisFunction2[dom.Node|js.Array[NewDatum],js.UndefOr[NewDatum], Int, String]): Update[NewDatum] = js.native
7777

7878

7979
def filter(selector: DatumFunction[Boolean]): T = js.native

src/test/scala/org/singlespaced/d3js/SelectionTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ object SelectionTest extends TestSuite {
2525
}
2626
'd3_dataWithKey_twoLoopsAndThisFunction {
2727
val sel:Selection[dom.EventTarget]=d3.selectAll("p")
28-
val function= { (t: dom.EventTarget | Int ,d:js.UndefOr[Int],i:Int) =>
28+
val function= { (t: dom.Node | js.Array[Int] ,d:js.UndefOr[Int],i:Int) =>
2929
//dom.window.console.log("d is "+d+" and i is "+i+" and this is "+t)
3030
"a"
3131
}
32-
sel.data[Int](js.Array(5),function).enter().append("p")
32+
sel.data[Int](js.Array(5,7,8),function).enter().append("p")
3333
}
3434
'd3_dataWithKey_simpleFunction {
3535
//arrange

0 commit comments

Comments
 (0)