Merge pull request #1 from fourstix/fourstix-patch-1

fourstix · web-flow · commit 1ba8535fd914 · 2018-08-21T12:04:28.000-04:00
Fixed a fence post error in the Display Custom Character function
diff --git a/firmware/OpenLCD/OpenLCD.ino b/firmware/OpenLCD/OpenLCD.ino
@@ -262,8 +262,8 @@ void updateDisplay()
       modeRecordCustomChar = true; //Change to this special mode
     }
 
-    //Display custom characters
-    else if (incoming >= 35 && incoming <= 43)
+    //Display custom characters, 8 characters allowed, 35 to 42 inclusive
+    else if (incoming >= 35 && incoming <= 42)
     {
       SerLCD.write(byte(incoming - 35)); //You write location zero to display customer char 0
     }
@@ -438,4 +438,4 @@ void displayFrameBuffer(void)
 
   //Return the cursor to its original position
   SerLCD.setCursor(characterCount % settingLCDwidth, characterCount / settingLCDwidth);
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -262,8 +262,8 @@ void updateDisplay()`
`262`	`262`	`modeRecordCustomChar = true; //Change to this special mode`
`263`	`263`	`}`
`264`	`264`
`265`		`- //Display custom characters`
`266`		`- else if (incoming >= 35 && incoming <= 43)`
	`265`	`+ //Display custom characters, 8 characters allowed, 35 to 42 inclusive`
	`266`	`+ else if (incoming >= 35 && incoming <= 42)`
`267`	`267`	`{`
`268`	`268`	`SerLCD.write(byte(incoming - 35)); //You write location zero to display customer char 0`
`269`	`269`	`}`
`@@ -438,4 +438,4 @@ void displayFrameBuffer(void)`
`438`	`438`
`439`	`439`	`//Return the cursor to its original position`
`440`	`440`	`SerLCD.setCursor(characterCount % settingLCDwidth, characterCount / settingLCDwidth);`
`441`		`-}`
	`441`	`+}`