Move UART1 serial test into display

Author: nseidle

Firmware/RTK_Surveyor/Display.ino

@@ -1429,8 +1429,21 @@ void paintSystemTest()
     oled.setCursor(xOffset, yOffset + (5 * charHeight) ); //x, y
     oled.print(macAddress);
     oled.print(":");
+
+    //Verify the ESP UART2 can communicate TX/RX to ZED UART1
     if (zedUartPassed == false)
-      oled.print(F("FAIL"));
+    {
+      SFE_UBLOX_GNSS myGNSS;
+
+      //begin() attempts 3 connections
+      if (myGNSS.begin(serialGNSS) == true)
+      {
+        zedUartPassed = true;
+        oled.print(F("OK"));
+      }
+      else
+        oled.print(F("FAIL"));
+    }
     else
       oled.print(F("OK"));
   }

Firmware/RTK_Surveyor/States.ino

@@ -641,24 +641,12 @@ void updateSystemState()
           //Debounce entry into test menu
           if (millis() - lastTestMenuChange > 500)
           {
+            zedUartPassed = false;
+            
             //Enable RTCM 1230. This is the GLONASS bias sentence and is transmitted
             //even if there is no GPS fix. We use it to test serial output.
             i2cGNSS.enableRTCMmessage(UBX_RTCM_1230, COM_PORT_UART2, 1); //Enable message every second
 
-            //Verify the ESP UART2 can communicate TX/RX to ZED UART1
-            SFE_UBLOX_GNSS myGNSS;
-
-            //Attempt 3 connections
-            for (int x = 0 ; x < 3 ; x++)
-            {
-              if (myGNSS.begin(serialGNSS) == true)
-              {
-                zedUartPassed = true;
-                break;
-              }
-              delay(250);
-            }
-
             changeState(STATE_TESTING);
           }
         }

Firmware/RTK_Surveyor/System.ino

@@ -226,12 +226,12 @@ bool configureUbloxModule()
   if (getSerialRate(COM_PORT_UART1) != settings.dataPortBaud)
   {
     Serial.println(F("Updating UART1 rate"));
-    i2cGNSS.setSerialRate(settings.dataPortBaud, COM_PORT_UART1); //Set UART1 to 115200
+    i2cGNSS.setSerialRate(settings.dataPortBaud, COM_PORT_UART1);
   }
-  if (getSerialRate(COM_PORT_UART2) != settings.radioPortBaud)
+  if (getSerialRate(COM_PORT_UART2) != settings.radioPortBaud) //Defaults to 460800 to maximize message output support
   {
     Serial.println(F("Updating UART2 rate"));
-    i2cGNSS.setSerialRate(settings.radioPortBaud, COM_PORT_UART2); //Set UART2 to 57600 to match SiK telemetry radio firmware default
+    i2cGNSS.setSerialRate(settings.radioPortBaud, COM_PORT_UART2); //Defaults to 57600 to match SiK telemetry radio firmware default
   }
 
   if (response == false)