moved/changed how to handle core platform functions - define funcs in core toolkit, provide impl in platform specific driver - better than the namespace thing

Author: gigapod

src/sfeTk/sfeToolkit.cpp

@@ -73,26 +73,3 @@ uint32_t sfeToolkit::byte_swap(uint32_t i)
     return ((i << 24) & 0xff000000) | ((i << 8) & 0x00ff0000) | ((i >> 8) & 0x0000ff00) | ((i >> 24) & 0x000000ff);
 #endif
 }
-
-void sfeToolkit::delay_ms(uint32_t ms)
-{
-    // right now we use the Arduino delay function - future we need to abstract out a driver
-
-#if defined(ARDUINO)
-    delay(ms);
-#else
-#error // we need to implement a delay function
-// we need to implement a delay function
-#endif
-}
-
-uint32_t sfeToolkit::ticks_ms(void)
-{
-#if defined(ARDUINO)
-    return millis();
-#else
-#error // we need to implement a delay function
-// we need to implement a delay function
-#endif
-    return 0;
-}

src/sfeTk/sfeToolkit.h

@@ -52,7 +52,13 @@ uint8_t byte_swap(uint8_t i);
 uint16_t byte_swap(uint16_t i);
 uint32_t byte_swap(uint32_t i);
 
-void delay_ms(uint32_t ms);
-uint32_t ticks_ms(void);
+}; // namespace sfeToolkit
 
-}; // namespace sfeToolkit
+// Area for platform specific implementations. The interface/functions are 
+// defined here, with the expectation that the platform provides the implementation.
+
+// delay in milliseconds
+void sfeTk_delay_ms(uint32_t ms);
+
+// ticks in milliseconds
+uint32_t sfeTk_ticks_ms(void);

src/sfeTkArduino.cpp

@@ -0,0 +1,37 @@
+/*
+@brief sfeTkArduino.cpp
+
+The MIT License (MIT)
+
+Copyright (c) 2023 SparkFun Electronics
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions: The
+above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED
+"AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT
+NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
+PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
+ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+*/
+
+#include <Arduino.h>
+
+// Implements the sfeToolkit functions for the Arduino platform
+
+void sfeTk_delay_ms(uint32_t ms)
+{
+    delay(ms);
+}
+
+uint32_t sfeTk_ticks_ms(void)
+{
+    return millis();
+}