Skip to content

Commit a497812

Browse files
committed
CoreFoundation: we only support /MD builds on Winddows
The static CRT is fraught with peril. Simply assume that we will never support it - full ostrich mode enabled!
1 parent c2a79a6 commit a497812

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

CoreFoundation/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,11 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL Darwin)
326326
PRIVATE
327327
-DDEPLOYMENT_TARGET_MACOSX)
328328
elseif(CMAKE_SYSTEM_NAME STREQUAL Windows)
329+
# NOTE(compnerd) we only support building with the dynamic CRT as using the
330+
# static CRT causes problems for users of the library.
331+
target_compile_definitions(CoreFoundation
332+
PRIVATE
333+
-D_DLL)
329334
target_compile_definitions(CoreFoundation
330335
PRIVATE
331336
-DDEPLOYMENT_TARGET_WINDOWS)

0 commit comments

Comments
 (0)