[BitcodeReader] Remove dead increment (llvm#98412)

tstellar · web-flow · commit ce2b28055330 · 2024-07-11T17:42:11.000-07:00
This was found by the Clang Static Analyzer.
diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
@@ -4381,7 +4381,6 @@ Error BitcodeReader::parseGlobalIndirectSymbolRecord(
       return error("Malformed partition, too large.");
     NewGA->setPartition(
         StringRef(Strtab.data() + Record[OpNum], Record[OpNum + 1]));
-    OpNum += 2;
   }
 
   ValueList.push_back(NewGA, getVirtualTypeID(NewGA->getType(), TypeID));

Original file line number	Diff line number	Diff line change
`@@ -4381,7 +4381,6 @@ Error BitcodeReader::parseGlobalIndirectSymbolRecord(`
`4381`	`4381`	`return error("Malformed partition, too large.");`
`4382`	`4382`	`NewGA->setPartition(`
`4383`	`4383`	`StringRef(Strtab.data() + Record[OpNum], Record[OpNum + 1]));`
`4384`		`- OpNum += 2;`
`4385`	`4384`	`}`
`4386`	`4385`
`4387`	`4386`	`ValueList.push_back(NewGA, getVirtualTypeID(NewGA->getType(), TypeID));`