Skip to content

Commit 5b3bc1a

Browse files
chessvivekwilkinsona
authored andcommitted
Remove assumptions about ordering when comparing JSON in tests
See gh-30514
1 parent 70fa7e5 commit 5b3bc1a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

spring-boot-project/spring-boot-autoconfigure/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ dependencies {
233233
testImplementation("org.junit.jupiter:junit-jupiter")
234234
testImplementation("org.mockito:mockito-core")
235235
testImplementation("org.mockito:mockito-junit-jupiter")
236+
testImplementation("org.skyscreamer:jsonassert")
236237
testImplementation("org.springframework:spring-test")
237238
testImplementation("org.springframework.kafka:spring-kafka-test")
238239
testImplementation("org.springframework.security:spring-security-test")

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/gson/GsonAutoConfigurationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.gson.GsonBuilder;
3030
import com.google.gson.LongSerializationPolicy;
3131
import org.junit.jupiter.api.Test;
32+
import org.skyscreamer.jsonassert.JSONAssert;
3233

3334
import org.springframework.boot.autoconfigure.AutoConfigurations;
3435
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@@ -150,7 +151,7 @@ void additionalGsonBuilderCustomization() {
150151
void customGsonBuilder() {
151152
this.contextRunner.withUserConfiguration(GsonBuilderConfig.class).run((context) -> {
152153
Gson gson = context.getBean(Gson.class);
153-
assertThat(gson.toJson(new DataObject())).isEqualTo("{\"data\":1,\"owner\":null}");
154+
JSONAssert.assertEquals(gson.toJson(new DataObject()), "{\"data\":1,\"owner\":null}", false);
154155
});
155156
}
156157

0 commit comments

Comments
 (0)