Merge pull request #36270 from spencergibb

jonatan-ivanov · jonatan-ivanov · commit 6041fe9b7a47 · 2023-07-06T16:15:01.000-07:00
* pr/36270: Skip int conversion in ClientHttpRequestFactories Closes gh-36270
diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/client/ClientHttpRequestFactories.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/client/ClientHttpRequestFactories.java
@@ -285,7 +285,7 @@ static JdkClientHttpRequestFactory get(ClientHttpRequestFactorySettings settings
 			java.net.http.HttpClient httpClient = createHttpClient(settings.connectTimeout(), settings.sslBundle());
 			JdkClientHttpRequestFactory requestFactory = new JdkClientHttpRequestFactory(httpClient);
 			PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
-			map.from(settings::readTimeout).asInt(Duration::toMillis).to(requestFactory::setReadTimeout);
+			map.from(settings::readTimeout).to(requestFactory::setReadTimeout);
 			return requestFactory;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ static JdkClientHttpRequestFactory get(ClientHttpRequestFactorySettings settings`
`285`	`285`	`java.net.http.HttpClient httpClient = createHttpClient(settings.connectTimeout(), settings.sslBundle());`
`286`	`286`	`JdkClientHttpRequestFactory requestFactory = new JdkClientHttpRequestFactory(httpClient);`
`287`	`287`	`PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();`
`288`		`- map.from(settings::readTimeout).asInt(Duration::toMillis).to(requestFactory::setReadTimeout);`
	`288`	`+ map.from(settings::readTimeout).to(requestFactory::setReadTimeout);`
`289`	`289`	`return requestFactory;`
`290`	`290`	`}`
`291`	`291`