Skip to content

Commit c66ef0e

Browse files
committed
Merge pull request #23799 from garyrussell
* pr/23799: Polish "Remove RabbitMQ AutoConfig Boolean Coercion" Remove RabbitMQ AutoConfig Boolean Coercion Closes gh-23799
2 parents da75330 + d0975d6 commit c66ef0e

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/SimpleRabbitListenerContainerFactoryConfigurer.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ public void configure(SimpleRabbitListenerContainerFactory factory, ConnectionFa
4040
map.from(config::getMaxConcurrency).whenNonNull().to(factory::setMaxConcurrentConsumers);
4141
map.from(config::getBatchSize).whenNonNull().to(factory::setBatchSize);
4242
map.from(config::isConsumerBatchEnabled).to(factory::setConsumerBatchEnabled);
43-
if (config.isConsumerBatchEnabled()) {
44-
factory.setDeBatchingEnabled(true);
45-
}
4643
}
4744

4845
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/amqp/RabbitAutoConfigurationTests.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
import com.rabbitmq.client.impl.DefaultCredentialsProvider;
3434
import org.aopalliance.aop.Advice;
3535
import org.junit.jupiter.api.Test;
36-
import org.mockito.InOrder;
37-
import org.mockito.Mockito;
3836

3937
import org.springframework.amqp.core.AcknowledgeMode;
4038
import org.springframework.amqp.core.AmqpAdmin;
@@ -556,17 +554,13 @@ void testSimpleRabbitListenerContainerFactoryConfigurerUsesConfig() {
556554
void testSimpleRabbitListenerContainerFactoryConfigurerEnableDeBatchingWithConsumerBatchEnabled() {
557555
this.contextRunner.withUserConfiguration(TestConfiguration.class)
558556
.withPropertyValues("spring.rabbitmq.listener.type:direct",
559-
"spring.rabbitmq.listener.simple.consumer-batch-enabled:true",
560-
"spring.rabbitmq.listener.simple.de-batching-enabled:false")
557+
"spring.rabbitmq.listener.simple.consumer-batch-enabled:true")
561558
.run((context) -> {
562559
SimpleRabbitListenerContainerFactoryConfigurer configurer = context
563560
.getBean(SimpleRabbitListenerContainerFactoryConfigurer.class);
564561
SimpleRabbitListenerContainerFactory factory = mock(SimpleRabbitListenerContainerFactory.class);
565562
configurer.configure(factory, mock(ConnectionFactory.class));
566-
InOrder inOrder = Mockito.inOrder(factory);
567563
verify(factory).setConsumerBatchEnabled(true);
568-
inOrder.verify(factory).setDeBatchingEnabled(false);
569-
inOrder.verify(factory).setDeBatchingEnabled(true);
570564
});
571565
}
572566

0 commit comments

Comments
 (0)