Skip to content

Add example of default Cloud Native Buildpacks Builder #19967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Jan 28, 2020 · 4 comments
Closed

Add example of default Cloud Native Buildpacks Builder #19967

snicoll opened this issue Jan 28, 2020 · 4 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jan 28, 2020

The build plugins use the cloudfoundry/cnb:0.0.43-bionic Builder by default, which bundles the OpenJDK Buildpack. The OpenJDK Buildpack exposes a number of options as env variables, see https://github.com/cloudfoundry/openjdk-cnb/blob/master/README.md.

A couple examples demonstrating the use of the default builder with the OpenJDK Buildpack would be interesting to help users getting started.

@snicoll snicoll added the type: documentation A documentation update label Jan 28, 2020
@snicoll snicoll added this to the 2.3.x milestone Jan 28, 2020
@scottfrederick
Copy link
Contributor

scottfrederick commented Jan 28, 2020

The default builder includes several buildpacks that might influence how a Boot app gets configured in the resulting container. We should look at these other Java-related buildpacks as well to see if any of them have env variables that we might want to document (for example https://github.com/cloudfoundry/debug-cnb/blob/master/README.md or https://github.com/cloudfoundry/build-system-cnb/blob/master/README.md).

@snicoll
Copy link
Member Author

snicoll commented Aug 31, 2020

I am starting to wonder if this is a good idea considering that some options have changed quite a lot recently and keeping them in sync on our side is challenging (that can be a problem for users on its own as well). Flagging for team attention to discuss this again.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Aug 31, 2020
@nebhale
Copy link
Contributor

nebhale commented Aug 31, 2020

I agree that Boot should probably kick out to Paketo Java Buildpack documentation that contains an up-to-date collection of possible configuration options. We'll be working on that over the next couple of weeks.

Also, it should be noted that when staging happens, all available configuration options are printed as part of the logs.

@scottfrederick
Copy link
Contributor

Paketo buildpacks documentation has been updated, so the Spring Boot docs can now link to the relevant section in paketo.io: https://paketo.io/docs/buildpacks/configuration/#environment-variables.

We should include a disclaimer that the information provided by this link only applies when the Paketo builder and buildpacks are used, and other CNB implementations might work differently.

@scottfrederick scottfrederick removed the for: team-attention An issue we'd like other members of the team to review label Oct 2, 2020
@scottfrederick scottfrederick self-assigned this Oct 8, 2020
@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.5 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants