Skip to content

Document how JAVA_OPTS can be used with the buildpack #21582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue May 26, 2020 · 6 comments
Closed

Document how JAVA_OPTS can be used with the buildpack #21582

philwebb opened this issue May 26, 2020 · 6 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

See #21483 (comment)

@fernandezseb
Copy link
Contributor

Hey, I'd like to take on this task if that's okay.

@nebhale
Copy link
Contributor

nebhale commented Jul 30, 2020

@philwebb We can do some additional documentation in our buildpacks as well to help with this as well.

@snicoll
Copy link
Member

snicoll commented Aug 31, 2020

We can document something on our side but I wonder if that's a good idea. By the time this issue was created, this was already renamed and the references above are outdated.

Looking at paketo-buildpacks/bellsoft-liberica@06551ec#diff-04c6e90faac2675aa89e2176d2eec7d8 it looks like the property to use now is JAVA_TOOL_OPTIONS.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Aug 31, 2020
@philwebb
Copy link
Member Author

@nebhale It does feel like some more user-facing Packeto documentation that we could link to would be very useful.

@nebhale
Copy link
Contributor

nebhale commented Aug 31, 2020

Yep, first thing on my list either during my downtime this week or just after SpringOne. The entire Paketo team is adding that as we speak.

@scottfrederick
Copy link
Contributor

Paketo buildpacks documentation has been updated, so the Spring Boot docs can now link to the relevant section in paketo.io: https://paketo.io/docs/buildpacks/language-family-buildpacks/java/#runtime-jvm-configuration.

We should include a disclaimer that the information provided by this link only applies when the Paketo builder and buildpacks are used, and other CNB implementations might work differently.

@scottfrederick scottfrederick removed the for: team-attention An issue we'd like other members of the team to review label Oct 2, 2020
@scottfrederick scottfrederick self-assigned this Oct 8, 2020
@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.5 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants