Skip to content

Don't adapt RandomPropertySource to ConfigurationPropertySource #21659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jun 3, 2020 · 0 comments
Closed

Don't adapt RandomPropertySource to ConfigurationPropertySource #21659

philwebb opened this issue Jun 3, 2020 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
2.4.0-RC1

Comments

@philwebb
Copy link
Member

philwebb commented Jun 3, 2020

Issue #21595 has got me thinking that there's no good reason to adapt any random property source to a configuration property source. I can't think of a good reason why you'd want to bind to a random source.
@philwebb philwebb added status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we'd like other members of the team to review labels Jun 3, 2020
@philwebb philwebb mentioned this issue Jun 3, 2020
Closed
@philwebb philwebb added this to the 2.4.x milestone Jun 3, 2020
@philwebb philwebb added type: task A general task status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged type: task A general task labels Jun 3, 2020
@philwebb philwebb removed the status: noteworthy A noteworthy issue to call out in the release notes label Oct 28, 2020
@philwebb philwebb modified the milestones: 2.4.x, 2.4.0-RC1 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-RC1
Development

No branches or pull requests
1 participant
@philwebb