Skip to content

UndertowWebServerFactoryCustomizer does not support Options but only UndertowOptions #22502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjuchniewicz opened this issue Jul 22, 2020 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@tjuchniewicz
Copy link

UndertowWebServerFactoryCustomizer can map properties from:

  • server.undertow.options.server.*
  • server.undertow.options.socket.*
    into:
  • builder.setSocketOption(...)
  • builder.setSocketOption(...)

but it does not support org.xnio.Options but only UndertowOptions, see: https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/embedded/UndertowWebServerFactoryCustomizer.java#L141

To use builder.setSocketOption(...) we need properties from org.xnio.Options.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2020
@wilkinsona
Copy link
Member

Thanks for the report. This looks like a bug to me. As far as I can tell, none of the options on UndertowOptions is intended for use as a socket option. This means that the server.undertow.options.socket.* properties are of no use as currently implemented.

@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 22, 2020
@wilkinsona wilkinsona added this to the 2.2.x milestone Jul 22, 2020
@wilkinsona wilkinsona self-assigned this Jul 27, 2020
@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.10 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants