Skip to content

Rename neo4j.version to neo4j-java-driver.version #22952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michael-simons opened this issue Aug 14, 2020 · 2 comments
Closed

Rename neo4j.version to neo4j-java-driver.version #22952

michael-simons opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@michael-simons
Copy link
Contributor

In Spring Boot 2.4.0-M2, neo4j.version will probably lead to confusion: It is currently used to specify the version of the Neo4j Java Driver which is most often not the same as the Neo4j server version.

I would much appreciate a change back to

<neo4j-java-driver.version>4.1.1</neo4j-java-driver.version>

As it was in the independent driver starter we at Neo4j developed.

Paging @meistermeier, too

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 14, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 14, 2020
@philwebb philwebb added this to the 2.4.x milestone Aug 14, 2020
@snicoll snicoll changed the title 2.4.0.M2: Property neo4j.version will cause confusion. Rename neo4j.version to neo4j-java-driver.version Aug 18, 2020
@snicoll
Copy link
Member

snicoll commented Aug 18, 2020

The version is inferred by the name of the dependency in spring-boot-dependencies and it was originally contributed as Neo4j.

It's easy enough to rename that to Neo4j Java Driver and I agree it would be better indeed. Thanks for the suggestion.

@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M3 Aug 18, 2020
@michael-simons
Copy link
Contributor Author

I guess that was an oversight on our side in those huge PRs. Thanks for the quick fix, much appreciated.

@snicoll snicoll self-assigned this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants