Skip to content

UndertowWebServerFactoryCustomizer requires commons lang via an unintended import on ClassUtils #23059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ionelmanolache opened this issue Aug 24, 2020 · 3 comments
Assignees
Labels
type: regression A regression from a previous release
Milestone

Comments

@ionelmanolache
Copy link

Hi,

I use Undertow and after upgraded to v2.3.3, app failed to start with error NoClassDefFoundError;org.apache.commons.lang.ClassUtils in 'UndertowWebServerFactoryCustomizer'
(see commit log f0d9002)

file https://github.com/spring-projects/spring-boot/commits/master/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/embedded/UndertowWebServerFactoryCustomizer.java

Thank you and best regards,
Ionel.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 24, 2020
@snicoll
Copy link
Member

snicoll commented Aug 24, 2020

Oops, thank you very much for the report. We meant to import ClassUtils from the core framework there.

@snicoll snicoll added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 24, 2020
@snicoll snicoll added this to the 2.3.4 milestone Aug 24, 2020
@snicoll snicoll changed the title UndertowWebServerFactoryCustomizer - error NoClassDefFoundError for org.apache.commons.lang.ClassUtils UndertowWebServerFactoryCustomizer requires commons lang via an unintended import on ClassUtils Aug 24, 2020
@snicoll snicoll self-assigned this Aug 24, 2020
@wilkinsona
Copy link
Member

This needs to be fixed in 2.2.x too. Thankfully we haven't released that one yet.

@snicoll
Copy link
Member

snicoll commented Aug 24, 2020

The import should have been prevented by a Checkstyle rule. Unfortunately it doesn't work as expected, I've created a separate issue to revisit it (#23062)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

4 participants