Skip to content

BootJar.getConfigurations() should not be public API #23527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Sep 29, 2020 · 0 comments
Closed

BootJar.getConfigurations() should not be public API #23527

wilkinsona opened this issue Sep 29, 2020 · 0 comments
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
2.3.5

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Sep 29, 2020 •
edited
Loading

The getConfigurations() method was introduced in this commit. It's only used for testing but it's protected and is therefore part of the public API. We should deprecate it in favour of Project.getConfigurations() so that we can remove it in the future.

Ideally, I'd like to do this in 2.3.x.
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Sep 29, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Oct 12, 2020
@wilkinsona wilkinsona added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review labels Oct 12, 2020
@wilkinsona wilkinsona changed the title Deprecate BootJar.getConfigurations() in favour of getConfigurations() on org.gradle.api.Project BootJar.getConfigurations() should not be public API Oct 12, 2020
@somayaj somayaj mentioned this issue Oct 16, 2020
Closed
@wilkinsona wilkinsona self-assigned this Oct 17, 2020
@wilkinsona wilkinsona mentioned this issue Oct 17, 2020
Closed
@wilkinsona wilkinsona modified the milestones: 2.3.x, 2.3.5 Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.3.5
Development

No branches or pull requests
1 participant
@wilkinsona