Skip to content

Security properties appendix contains spring.session and spring.ldap properties that belong elsewhere #23558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghusta opened this issue Oct 1, 2020 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@ghusta
Copy link
Contributor

ghusta commented Oct 1, 2020

When looking at the documentation for Common Application properties, at the Security section, I also found the properties prefixed by spring.session.

In my opinion, the properties related to Spring Session would deserve their own section, as they are not really related to security.

What do you think ?


I found the merge of these properties is done there : https://github.com/spring-projects/spring-boot/blob/master/buildSrc/src/main/java/org/springframework/boot/build/context/properties/DocumentConfigurationProperties.java#L80

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 1, 2020
@vpavic
Copy link
Contributor

vpavic commented Oct 1, 2020

This is a good point.

While it might seem a bit odd a first, these are actually even a fit for the Server properties section, as Spring Session effectively replaces container's default session management facilities. The auto-configuration even consumes the value of server.servlet.session.timeout property when configuring Spring Session.

@ghusta
Copy link
Contributor Author

ghusta commented Oct 2, 2020

Good suggestion, it could also fit server properties, indeed.

@wilkinsona wilkinsona changed the title Improve documentation for Spring Session properties Security properties appendix contains spring.session and spring.ldap properties that belong elsewhere Nov 9, 2020
@wilkinsona
Copy link
Member

Thanks, @ghusta. We're going to move the LDAP properties to the Data section and the Session properties to the Web section.

@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 9, 2020
@wilkinsona wilkinsona added this to the 2.2.x milestone Nov 9, 2020
@snicoll snicoll self-assigned this Nov 9, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.2.12 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants