Skip to content

Address inconsistencies in enabling configuration properties #23593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Oct 6, 2020 · 1 comment
Closed

Address inconsistencies in enabling configuration properties #23593

snicoll opened this issue Oct 6, 2020 · 1 comment
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
2.4.0-M4

Comments

@snicoll
Copy link
Member

snicoll commented Oct 6, 2020 •
edited
Loading

Supporting constructor binding on 3rd party classes the way @ImportAsConfigurationPropertiesBean does leads to some inconsistensies. The main one is that the annotation use constructor binding by default, which is at odds with what @ConfigurationProperties is doing.

This issue is to essentially revert #23172 introduced in the previous milestone.
@snicoll snicoll added the type: task A general task label Oct 6, 2020
@snicoll snicoll added this to the 2.4.0-M4 milestone Oct 6, 2020
@snicoll snicoll changed the title Revert @ImportAsConfigurationPropertiesBean Address inconsistencies in enabling configuration properties Oct 6, 2020
@snicoll snicoll added type: enhancement A general enhancement and removed type: task A general task labels Oct 6, 2020
@snicoll snicoll self-assigned this Oct 6, 2020
@snicoll snicoll closed this as completed in 1296b4d Oct 7, 2020
@snicoll
Copy link
Member Author

snicoll commented Oct 7, 2020

I've created #23607 so that we give this feature another go.

@snicoll snicoll mentioned this issue Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M4
Development

No branches or pull requests
1 participant
@snicoll