Skip to content

Override Undertow's defaults so that the request URL of a forwarded request is spec-compliant and make it configurable via an application property #23619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Oct 8, 2020 · 0 comments
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Oct 8, 2020

By default, Undertow preserves the original request URL when a request is forwarded. This does not comply with the Servlet spec which states the following:

If this request has been forwarded using RequestDispatcher.forward(javax.servlet.ServletRequest, javax.servlet.ServletResponse), the server path in the reconstructed URL must reflect the path used to obtain the RequestDispatcher, and not the server path specified by the client.

We should override Undertow's default so that it's spec compliant and provide a configuration property so that users can easily restore the current behaviour if they are relying on it.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Oct 8, 2020
@wilkinsona wilkinsona added this to the 2.4.x milestone Oct 8, 2020
@wilkinsona wilkinsona added the status: noteworthy A noteworthy issue to call out in the release notes label Oct 8, 2020
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.4.0-M4 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant