Skip to content

Rename spring.security.saml2.relyingparty.*.relying-party-entity-id to spring.security.saml2.relyingparty.*.entityId #23745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Oct 19, 2020 · 0 comments
Closed

Rename spring.security.saml2.relyingparty.*.relying-party-entity-id to spring.security.saml2.relyingparty.*.entityId #23745

wilkinsona opened this issue Oct 19, 2020 · 0 comments
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
2.4.0-RC1

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Oct 19, 2020 •
edited
Loading

#22258 added a property, spring.security.saml2.relyingparty.*.relying-party-entity-id, for configuring the entity id. It maps onto Spring Security's RelyingPartyRegistration.Builder.entityId(String) method. With hindsight, and thanks to @dawi for the suggestion, spring.security.saml2.relyingparty.*.entityId would be a better name for the property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-RC1
Development

No branches or pull requests
1 participant
@wilkinsona