Skip to content

Disable mappings endpoint related infrastructure when endpoint isn't available #23977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Oct 30, 2020 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

From some analysis by @aclement, when the mappings endpoint is unavailable we still auto-configure some beans that, generally speaking, are only used by the endpoint. On the servlet side we'll typically define three beans that aren't needed and on the reactive side we'll define one.

While it's not beyond the realms of possibility that someone is using the defined beans without using the endpoint, I think it's unlikely. We should consider making all the infrastructure conditional on the mappings endpoint being available so that users just pay (in startup time and memory footprint) for what they're using.

@wilkinsona wilkinsona added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Oct 30, 2020
@wilkinsona
Copy link
Member Author

There may be other areas in Actuator where we could make a similar change. Flagging for team attention to see how far, if at all, we want to take this.

@philwebb philwebb added this to the 2.5.x milestone Oct 30, 2020
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Oct 30, 2020
@wilkinsona wilkinsona self-assigned this Jan 18, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.0-M1 Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants