Skip to content

Remove message attribute instead of blanking it when Include.MESSAGE is not set #24712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jan 8, 2021 · 1 comment
Closed

Remove message attribute instead of blanking it when Include.MESSAGE is not set #24712

philwebb opened this issue Jan 8, 2021 · 1 comment
Assignees
@wilkinsona
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone
2.5.0-M2

Comments

@philwebb
Copy link
Member

philwebb commented Jan 8, 2021

See #24661 for some more background. We originally blanked the message field rather than removing it. This was probably for back-compatibility, but we think removing it would be more consistent.
@philwebb philwebb added type: enhancement A general enhancement status: noteworthy A noteworthy issue to call out in the release notes labels Jan 8, 2021
@philwebb philwebb added this to the 2.5.x milestone Jan 8, 2021
@philwebb philwebb mentioned this issue Jan 8, 2021
Closed
@weixsun
Copy link
Contributor

weixsun commented Jan 9, 2021

Mark 👀
Removing the "message" attribute will indeed be consistent with "trace" attribute etc.

@wilkinsona wilkinsona self-assigned this Jan 22, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.0-M2 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.0-M2
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @weixsun