Skip to content

Raise the minimum supported version of Gradle to 7.3 #28100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Sep 22, 2021 · 7 comments
Closed

Raise the minimum supported version of Gradle to 7.3 #28100

wilkinsona opened this issue Sep 22, 2021 · 7 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Sep 22, 2021
@wilkinsona wilkinsona added this to the 3.0.x milestone Sep 22, 2021
@wilkinsona wilkinsona self-assigned this Sep 22, 2021
@scottfrederick scottfrederick added the status: blocked An issue that's blocked on an external project change label Nov 1, 2021
@wilkinsona
Copy link
Member Author

We need to use Gradle 7.3 as a minimum. While Gradle 7.2 runs on Java 17, it falls over when it encounters Java 17 bytecode such as in our Gradle plugin.

@wilkinsona wilkinsona changed the title Raise the minimum supported version of Gradle to 7.2 Raise the minimum supported version of Gradle to 7.3 Nov 11, 2021
@vpavic
Copy link
Contributor

vpavic commented Nov 23, 2021

This doesn't sound right to me.

The cost of the upgrade to Spring Framework 6.x/Spring Boot 3.x will be high enough due to the steep increase of the baseline, and Gradle's toolchains support can actually help there by preventing that cost from spilling into the build infrastructure.

However by building the plugin using Java 17 you're negating that advantage.

@wilkinsona
Copy link
Member Author

By the time Spring Boot 3 has GAed, Gradle 7.3 will be 12 months old. If anything, further increases of the minimum supported version of Gradle will be made during the course of Boot 3.0's development. We may even get to the point where we support the last Gradle 7.x release and Gradle 8.x, depending on their release schedule.

@vpavic
Copy link
Contributor

vpavic commented Nov 23, 2021

Sorry, I wasn't clear enough - I was referring to the fact that the build plugin is built using Java 17 effectively makes it impossible to leverage Gradle toolchains and keep the pipeline running on older version of Java.

@wilkinsona
Copy link
Member Author

This change is for Spring Boot 3.0 where the entire portfolio will have a Java 17 baseline. Why would you want to run Gradle on an older version of Java?

@vpavic
Copy link
Contributor

vpavic commented Nov 23, 2021

Because something else in the build pipeline (other plugins etc.) isn't ready for upgrade?

@wilkinsona
Copy link
Member Author

With 3.0's GA almost a year away, we'd prefer to cross that bridge if and when we come to it. In the meantime, please try out the snapshots and milestones once they're available and report any problems you find to the relevant projects.

@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-M1 Nov 30, 2021
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants