Polishing.

Move warning suppression to the class-level.

See #3901

Author: mp911de

spring-data-jpa/src/test/java/org/springframework/data/jpa/convert/threeten/Jsr310JpaConvertersUnitTests.java

@@ -17,10 +17,10 @@
 
 import static org.assertj.core.api.Assertions.*;
 
-import java.util.Arrays;
-
 import jakarta.persistence.AttributeConverter;
 
+import java.util.Arrays;
+
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
 
@@ -40,7 +40,6 @@ static Iterable<?> data() {
 				new Jsr310JpaConverters.ZoneIdConverter());
 	}
 
-
 	@ParameterizedTest
 	@MethodSource("data")
 	void convertersHandleNullValuesCorrectly(AttributeConverter<?, ?> converter) {

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/DeleteSpecificationUnitTests.java

@@ -39,7 +39,7 @@
  *
  * @author Mark Paluch
  */
-@SuppressWarnings("serial")
+@SuppressWarnings({ "unchecked", "deprecation" })
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
 class DeleteSpecificationUnitTests implements Serializable {
@@ -109,7 +109,6 @@ void specificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		DeleteSpecification<Object> transferredSpecification = (DeleteSpecification<Object>) deserialize(
 				serialize(specification));
 
@@ -125,7 +124,6 @@ void complexSpecificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		DeleteSpecification<Object> transferredSpecification = (DeleteSpecification<Object>) deserialize(
 				serialize(specification));
 

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/PredicateSpecificationUnitTests.java

@@ -38,7 +38,7 @@
  *
  * @author Mark Paluch
  */
-@SuppressWarnings("serial")
+@SuppressWarnings({ "unchecked", "deprecation" })
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
 class PredicateSpecificationUnitTests implements Serializable {
@@ -107,7 +107,6 @@ void specificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		PredicateSpecification<Object> transferredSpecification = (PredicateSpecification<Object>) deserialize(
 				serialize(specification));
 
@@ -123,7 +122,6 @@ void complexSpecificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		PredicateSpecification<Object> transferredSpecification = (PredicateSpecification<Object>) deserialize(
 				serialize(specification));
 

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java

@@ -26,7 +26,6 @@
 
 import java.io.Serializable;
 
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
@@ -44,24 +43,16 @@
  * @author Mark Paluch
  * @author Daniel Shuy
  */
-@SuppressWarnings("removal")
+@SuppressWarnings({ "unchecked", "deprecation" })
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
 class SpecificationUnitTests {
 
-	private Specification<Object> spec;
 	@Mock(serializable = true) Root<Object> root;
 	@Mock(serializable = true) CriteriaQuery<?> query;
 	@Mock(serializable = true) CriteriaBuilder builder;
-
 	@Mock(serializable = true) Predicate predicate;
 
-	@BeforeEach
-	void setUp() {
-
-		spec = (root, query, cb) -> predicate;
-	}
-
 	@Test // GH-1943
 	void emptyAllOfReturnsEmptySpecification() {
 
@@ -88,7 +79,6 @@ void specificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({ "unchecked", "deprecation"})
 		Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
 
 		assertThat(transferredSpecification).isNotNull();
@@ -103,7 +93,6 @@ void complexSpecificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({ "unchecked", "deprecation"})
 		Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
 
 		assertThat(transferredSpecification).isNotNull();
@@ -116,7 +105,6 @@ void andCombinesSpecificationsInOrder() {
 		Predicate secondPredicate = mock(Predicate.class);
 
 		Specification<Object> first = ((root1, query1, criteriaBuilder) -> firstPredicate);
-
 		Specification<Object> second = ((root1, query1, criteriaBuilder) -> secondPredicate);
 
 		first.and(second).toPredicate(root, query, builder);

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/UpdateSpecificationUnitTests.java

@@ -39,7 +39,7 @@
  *
  * @author Mark Paluch
  */
-@SuppressWarnings("serial")
+@SuppressWarnings({ "unchecked", "deprecation" })
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
 class UpdateSpecificationUnitTests implements Serializable {
@@ -109,7 +109,6 @@ void specificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		UpdateSpecification<Object> transferredSpecification = (UpdateSpecification<Object>) deserialize(
 				serialize(specification));
 
@@ -125,7 +124,6 @@ void complexSpecificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings({"unchecked", "deprecation"})
 		UpdateSpecification<Object> transferredSpecification = (UpdateSpecification<Object>) deserialize(
 				serialize(specification));