Skip to content

Commit 75f2942

Browse files
committed
DATAJPA-858 - Polishing.
Removed obsolete method from JpaQueryCreator. Tweaked ticket references in sample repository.
1 parent 5455b8c commit 75f2942

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

src/main/java/org/springframework/data/jpa/repository/query/JpaQueryCreator.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -169,19 +169,6 @@ private Predicate toPredicate(Part part, Root<?> root) {
169169
return new PredicateBuilder(part, root).build();
170170
}
171171

172-
/**
173-
* Returns a path to a {@link Comparable}.
174-
*
175-
* @param root
176-
* @param part
177-
* @return
178-
*/
179-
@SuppressWarnings({ "rawtypes" })
180-
private Expression<? extends Comparable> getComparablePath(Root<?> root, Part part) {
181-
182-
return getTypedPath(root, part);
183-
}
184-
185172
private <T> Expression<T> getTypedPath(Root<?> root, Part part) {
186173
return toExpressionRecursively(root, part.getProperty());
187174
}

src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -546,33 +546,33 @@ List<User> findUsersByFirstnameForSpELExpressionWithParameterIndexOnlyWithEntity
546546
String lastname);
547547

548548
/**
549-
* DATAJPA-606
549+
* @see DATAJPA-606
550550
*/
551551
List<User> findByAgeIn(Collection<Integer> ages);
552552

553553
/**
554-
* DATAJPA-606
554+
* @see DATAJPA-606
555555
*/
556556
List<User> queryByAgeIn(Integer[] ages);
557557

558558
/**
559-
* DATAJPA-606
559+
* @see DATAJPA-606
560560
*/
561561
List<User> queryByAgeInOrFirstname(Integer[] ages, String firstname);
562562

563563
/**
564-
* DATAJPA-677
564+
* @see DATAJPA-677
565565
*/
566566
@Query("select u from User u")
567567
Stream<User> findAllByCustomQueryAndStream();
568568

569569
/**
570-
* DATAJPA-677
570+
* @see DATAJPA-677
571571
*/
572572
Stream<User> readAllByFirstnameNotNull();
573573

574574
/**
575-
* DATAJPA-677
575+
* @see DATAJPA-677
576576
*/
577577
@Query("select u from User u")
578578
Stream<User> streamAllPaged(Pageable pageable);
@@ -583,12 +583,12 @@ List<User> findUsersByFirstnameForSpELExpressionWithParameterIndexOnlyWithEntity
583583
List<User> findByLastnameNotContaining(String part);
584584

585585
/**
586-
* DATAJPA-829
586+
* @see DATAJPA-829
587587
*/
588588
List<User> findByRolesContaining(Role role);
589589

590590
/**
591-
* DATAJPA-829
591+
* @see DATAJPA-829
592592
*/
593593
List<User> findByRolesNotContaining(Role role);
594594

0 commit comments

Comments
 (0)