Skip to content

Commit 1181bb1

Browse files
committed
Rename originsPattern to originPatterns
See gh-25016
1 parent 8632118 commit 1181bb1

File tree

8 files changed

+134
-119
lines changed

8 files changed

+134
-119
lines changed

spring-web/src/main/java/org/springframework/web/bind/annotation/CrossOrigin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@
109109
* See the Spring Framework reference for more on this filter.
110110
* @see #value
111111
*/
112-
String[] originsPatterns() default {};
112+
String[] originPatterns() default {};
113113

114114
/**
115115
* The list of request headers that are permitted in actual requests,

spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public class CorsConfiguration {
7777
private List<String> allowedOrigins;
7878

7979
@Nullable
80-
private List<Pattern> allowedOriginsPatterns;
80+
private List<Pattern> allowedOriginPatterns;
8181

8282
@Nullable
8383
private List<String> allowedMethods;
@@ -112,7 +112,7 @@ public CorsConfiguration() {
112112
*/
113113
public CorsConfiguration(CorsConfiguration other) {
114114
this.allowedOrigins = other.allowedOrigins;
115-
this.allowedOriginsPatterns = other.allowedOriginsPatterns;
115+
this.allowedOriginPatterns = other.allowedOriginPatterns;
116116
this.allowedMethods = other.allowedMethods;
117117
this.resolvedMethods = other.resolvedMethods;
118118
this.allowedHeaders = other.allowedHeaders;
@@ -158,14 +158,14 @@ else if (this.allowedOrigins == DEFAULT_PERMIT_ALL) {
158158
* Set the origins patterns to allow, e.g. {@code "*.com"}.
159159
* <p>By default this is not set.
160160
*/
161-
public CorsConfiguration setAllowedOriginsPatterns(@Nullable List<String> allowedOriginsPatterns) {
162-
if (allowedOriginsPatterns == null) {
163-
this.allowedOriginsPatterns = null;
161+
public CorsConfiguration setAllowedOriginPatterns(@Nullable List<String> allowedOriginPatterns) {
162+
if (allowedOriginPatterns == null) {
163+
this.allowedOriginPatterns = null;
164164
}
165165
else {
166-
this.allowedOriginsPatterns = new ArrayList<>(allowedOriginsPatterns.size());
167-
for (String pattern : allowedOriginsPatterns) {
168-
this.allowedOriginsPatterns.add(Pattern.compile(pattern));
166+
this.allowedOriginPatterns = new ArrayList<>(allowedOriginPatterns.size());
167+
for (String pattern : allowedOriginPatterns) {
168+
this.allowedOriginPatterns.add(Pattern.compile(pattern));
169169
}
170170
}
171171

@@ -176,30 +176,30 @@ public CorsConfiguration setAllowedOriginsPatterns(@Nullable List<String> allowe
176176
* Return the configured origins patterns to allow, or {@code null} if none.
177177
*
178178
* @see #addAllowedOriginPattern(String)
179-
* @see #setAllowedOriginsPatterns(List)
179+
* @see #setAllowedOriginPatterns(List)
180180
*/
181181
@Nullable
182-
public List<String> getAllowedOriginsPatterns() {
183-
if (this.allowedOriginsPatterns == null) {
182+
public List<String> getAllowedOriginPatterns() {
183+
if (this.allowedOriginPatterns == null) {
184184
return null;
185185
}
186-
if (this.allowedOriginsPatterns == DEFAULT_PERMIT_ALL_PATTERN) {
186+
if (this.allowedOriginPatterns == DEFAULT_PERMIT_ALL_PATTERN) {
187187
return DEFAULT_PERMIT_ALL_PATTERN_STR;
188188
}
189-
return this.allowedOriginsPatterns.stream().map(Pattern::toString).collect(Collectors.toList());
189+
return this.allowedOriginPatterns.stream().map(Pattern::toString).collect(Collectors.toList());
190190
}
191191

192192
/**
193193
* Add an origin pattern to allow.
194194
*/
195195
public void addAllowedOriginPattern(String originPattern) {
196-
if (this.allowedOriginsPatterns == null) {
197-
this.allowedOriginsPatterns = new ArrayList<>(4);
196+
if (this.allowedOriginPatterns == null) {
197+
this.allowedOriginPatterns = new ArrayList<>(4);
198198
}
199-
else if (this.allowedOriginsPatterns == DEFAULT_PERMIT_ALL_PATTERN) {
200-
setAllowedOriginsPatterns(DEFAULT_PERMIT_ALL_PATTERN_STR);
199+
else if (this.allowedOriginPatterns == DEFAULT_PERMIT_ALL_PATTERN) {
200+
setAllowedOriginPatterns(DEFAULT_PERMIT_ALL_PATTERN_STR);
201201
}
202-
this.allowedOriginsPatterns.add(Pattern.compile(originPattern));
202+
this.allowedOriginPatterns.add(Pattern.compile(originPattern));
203203
}
204204

205205
/**
@@ -413,7 +413,7 @@ public Long getMaxAge() {
413413
* </ul>
414414
*/
415415
public CorsConfiguration applyPermitDefaultValues() {
416-
if (this.allowedOrigins == null && this.allowedOriginsPatterns == null) {
416+
if (this.allowedOrigins == null && this.allowedOriginPatterns == null) {
417417
this.allowedOrigins = DEFAULT_PERMIT_ALL;
418418
}
419419
if (this.allowedMethods == null) {
@@ -455,13 +455,13 @@ public CorsConfiguration combine(@Nullable CorsConfiguration other) {
455455
}
456456
CorsConfiguration config = new CorsConfiguration(this);
457457
List<String> combinedOrigins = combine(getAllowedOrigins(), other.getAllowedOrigins());
458-
List<String> combinedOriginsPatterns = combine(getAllowedOriginsPatterns(), other.getAllowedOriginsPatterns());
459-
if (combinedOrigins == DEFAULT_PERMIT_ALL && combinedOriginsPatterns != DEFAULT_PERMIT_ALL_PATTERN_STR
460-
&& !CollectionUtils.isEmpty(combinedOriginsPatterns)) {
458+
List<String> combinedOriginPatterns = combine(getAllowedOriginPatterns(), other.getAllowedOriginPatterns());
459+
if (combinedOrigins == DEFAULT_PERMIT_ALL && combinedOriginPatterns != DEFAULT_PERMIT_ALL_PATTERN_STR
460+
&& !CollectionUtils.isEmpty(combinedOriginPatterns)) {
461461
combinedOrigins = null;
462462
}
463463
config.setAllowedOrigins(combinedOrigins);
464-
config.setAllowedOriginsPatterns(combinedOriginsPatterns);
464+
config.setAllowedOriginPatterns(combinedOriginPatterns);
465465
config.setAllowedMethods(combine(getAllowedMethods(), other.getAllowedMethods()));
466466
config.setAllowedHeaders(combine(getAllowedHeaders(), other.getAllowedHeaders()));
467467
config.setExposedHeaders(combine(getExposedHeaders(), other.getExposedHeaders()));
@@ -529,8 +529,8 @@ public String checkOrigin(@Nullable String requestOrigin) {
529529
}
530530
}
531531
}
532-
if (!ObjectUtils.isEmpty(this.allowedOriginsPatterns)) {
533-
for (Pattern allowedOriginsPattern : this.allowedOriginsPatterns) {
532+
if (!ObjectUtils.isEmpty(this.allowedOriginPatterns)) {
533+
for (Pattern allowedOriginsPattern : this.allowedOriginPatterns) {
534534
if (allowedOriginsPattern.pattern().equals(ALL_PATTERN)) {
535535
if (this.allowCredentials != Boolean.TRUE) {
536536
return ALL;

0 commit comments

Comments
 (0)