Skip to content

Commit 209c850

Browse files
committed
Align forRawClassAssignableFromTypeVariable with 5.1 assertion style
See gh-23321
1 parent e5bef10 commit 209c850

File tree

1 file changed

+15
-19
lines changed

1 file changed

+15
-19
lines changed

spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2018 the original author or authors.
2+
* Copyright 2002-2019 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -135,41 +135,41 @@ public void forRawClassWithNull() throws Exception {
135135
assertTrue(type.isAssignableFrom(String.class));
136136
}
137137

138-
@Test
139-
public void forRawClassAssignableFromTypeVariable() { // gh-23321
138+
@Test // gh-23321
139+
public void forRawClassAssignableFromTypeVariable() throws Exception {
140140
ResolvableType typeVariable = ResolvableType.forClass(ExtendsList.class).as(List.class).getGeneric();
141141
ResolvableType raw = ResolvableType.forRawClass(CharSequence.class);
142-
assertThat(raw.resolve()).isEqualTo(CharSequence.class);
143-
assertThat(typeVariable.resolve()).isEqualTo(CharSequence.class);
144-
assertThat(raw.resolve().isAssignableFrom(typeVariable.resolve())).isTrue();
145-
assertThat(typeVariable.resolve().isAssignableFrom(raw.resolve())).isTrue();
146-
assertThat(raw.isAssignableFrom(typeVariable)).isTrue();
147-
assertThat(typeVariable.isAssignableFrom(raw)).isTrue();
142+
assertThat(raw.resolve(), equalTo(CharSequence.class));
143+
assertThat(typeVariable.resolve(), equalTo(CharSequence.class));
144+
assertTrue(raw.resolve().isAssignableFrom(typeVariable.resolve()));
145+
assertTrue(typeVariable.resolve().isAssignableFrom(raw.resolve()));
146+
assertTrue(raw.isAssignableFrom(typeVariable));
147+
assertTrue(typeVariable.isAssignableFrom(raw));
148148
}
149149

150150
@Test
151-
public void forInstanceMustNotBeNull() {
151+
public void forInstanceMustNotBeNull() throws Exception {
152152
this.thrown.expect(IllegalArgumentException.class);
153153
this.thrown.expectMessage("Instance must not be null");
154154
ResolvableType.forInstance(null);
155155
}
156156

157157
@Test
158-
public void forInstanceNoProvider() {
158+
public void forInstanceNoProvider() throws Exception {
159159
ResolvableType type = ResolvableType.forInstance(new Object());
160160
assertThat(type.getType(), equalTo(Object.class));
161161
assertThat(type.resolve(), equalTo(Object.class));
162162
}
163163

164164
@Test
165-
public void forInstanceProvider() {
165+
public void forInstanceProvider() throws Exception {
166166
ResolvableType type = ResolvableType.forInstance(new MyGenericInterfaceType<>(String.class));
167167
assertThat(type.getRawClass(), equalTo(MyGenericInterfaceType.class));
168168
assertThat(type.getGeneric().resolve(), equalTo(String.class));
169169
}
170170

171171
@Test
172-
public void forInstanceProviderNull() {
172+
public void forInstanceProviderNull() throws Exception {
173173
ResolvableType type = ResolvableType.forInstance(new MyGenericInterfaceType<String>(null));
174174
assertThat(type.getType(), equalTo(MyGenericInterfaceType.class));
175175
assertThat(type.resolve(), equalTo(MyGenericInterfaceType.class));
@@ -443,12 +443,8 @@ public void getInterfaces() throws Exception {
443443
interfaces.add(interfaceType.toString());
444444
}
445445
assertThat(interfaces.toString(), equalTo(
446-
"["
447-
+ "java.io.Serializable, "
448-
+ "java.lang.Cloneable, "
449-
+ "java.util.List<java.lang.CharSequence>, "
450-
+ "java.util.RandomAccess"
451-
+ "]"));
446+
"[java.io.Serializable, java.lang.Cloneable, " +
447+
"java.util.List<java.lang.CharSequence>, java.util.RandomAccess]"));
452448
}
453449

454450
@Test

0 commit comments

Comments
 (0)