Skip to content

Commit 2b4ffe0

Browse files
committed
Consistent inclusion of baseUrl in URI_TEMPLATE attribute
Closes gh-31882
1 parent e7eaaad commit 2b4ffe0

File tree

2 files changed

+32
-5
lines changed

2 files changed

+32
-5
lines changed

spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,14 +231,16 @@ public RequestBodySpec uri(String uriTemplate, Object... uriVariables) {
231231

232232
@Override
233233
public RequestBodySpec uri(String uriTemplate, Map<String, ?> uriVariables) {
234-
attribute(URI_TEMPLATE_ATTRIBUTE, uriTemplate);
235-
return uri(uriBuilderFactory.expand(uriTemplate, uriVariables));
234+
UriBuilder uriBuilder = uriBuilderFactory.uriString(uriTemplate);
235+
attribute(URI_TEMPLATE_ATTRIBUTE, uriBuilder.toUriString());
236+
return uri(uriBuilder.build(uriVariables));
236237
}
237238

238239
@Override
239240
public RequestBodySpec uri(String uriTemplate, Function<UriBuilder, URI> uriFunction) {
240-
attribute(URI_TEMPLATE_ATTRIBUTE, uriTemplate);
241-
return uri(uriFunction.apply(uriBuilderFactory.uriString(uriTemplate)));
241+
UriBuilder uriBuilder = uriBuilderFactory.uriString(uriTemplate);
242+
attribute(URI_TEMPLATE_ATTRIBUTE, uriBuilder.toUriString());
243+
return uri(uriFunction.apply(uriBuilder));
242244
}
243245

244246
@Override

spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultWebClientTests.java

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.HashMap;
2222
import java.util.Map;
2323
import java.util.function.Consumer;
24+
import java.util.function.Function;
2425
import java.util.function.Predicate;
2526

2627
import org.junit.jupiter.api.BeforeEach;
@@ -110,7 +111,7 @@ public void uriBuilderWithUriTemplate() {
110111

111112
ClientRequest request = verifyAndGetRequest();
112113
assertThat(request.url().toString()).isEqualTo("/base/path/identifier?q=12");
113-
assertThat(request.attribute(WebClient.class.getName() + ".uriTemplate")).contains("/path/{id}");
114+
assertThat(request.attribute(WebClient.class.getName() + ".uriTemplate")).contains("/base/path/{id}");
114115
}
115116

116117
@Test
@@ -363,6 +364,30 @@ public void withNullAttribute() {
363364
assertThat(request.attribute("foo")).isNotPresent();
364365
}
365366

367+
@Test
368+
public void uriTemplateAttribute() {
369+
testUriTemplateAttribute(client -> client.get().uri("/{id}", 1), "/base/{id}");
370+
testUriTemplateAttribute(client -> client.get().uri("/{id}", Map.of("id", 1)), "/base/{id}");
371+
testUriTemplateAttribute(client -> client.get().uri("/{id}", builder -> builder.build(1)), "/base/{id}");
372+
}
373+
374+
private void testUriTemplateAttribute(
375+
Function<WebClient, WebClient.RequestHeadersSpec<?>> requestFn, String expectedPath) {
376+
377+
Map<String, Object> actual = new HashMap<>();
378+
ExchangeFilterFunction filter = (request, next) -> {
379+
actual.putAll(request.attributes());
380+
return next.exchange(request);
381+
};
382+
383+
requestFn.apply(this.builder.filter(filter).build())
384+
.retrieve().bodyToMono(Void.class)
385+
.block(Duration.ofSeconds(10));
386+
387+
String key = WebClient.class.getName() + ".uriTemplate";
388+
assertThat(actual.get(key)).isEqualTo(expectedPath);
389+
}
390+
366391
@Test
367392
public void apply() {
368393
WebClient client = this.builder

0 commit comments

Comments
 (0)