Avoid expensive assertions in web resource resolution

Closes gh-22955

Author: jhoeller

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilter.java

@@ -30,7 +30,6 @@
 import org.apache.commons.logging.LogFactory;
 
 import org.springframework.lang.Nullable;
-import org.springframework.util.Assert;
 import org.springframework.web.filter.GenericFilterBean;
 import org.springframework.web.util.UrlPathHelper;
 
@@ -87,7 +86,6 @@ public void setAttribute(String name, Object value) {
 					initLookupPath((ResourceUrlProvider) value);
 				}
 			}
-
 		}
 
 		private void initLookupPath(ResourceUrlProvider urlProvider) {
@@ -97,10 +95,12 @@ private void initLookupPath(ResourceUrlProvider urlProvider) {
 				String requestUri = pathHelper.getRequestUri(this);
 				String lookupPath = pathHelper.getLookupPathForRequest(this);
 				this.indexLookupPath = requestUri.lastIndexOf(lookupPath);
-				Assert.isTrue(this.indexLookupPath != -1, () ->
-						"Failed to find lookupPath '" + lookupPath + "' within requestUri '" + requestUri + ". " +
-						"Does the path have invalid encoded characters " +
-								"for characterEncoding=" + getRequest().getCharacterEncoding() + "?");
+				if (this.indexLookupPath == -1) {
+					throw new IllegalStateException(
+							"Failed to find lookupPath '" + lookupPath + "' within requestUri '" + requestUri + "'. " +
+							"Does the path have invalid encoded characters for characterEncoding '" +
+							getRequest().getCharacterEncoding() + "'?");
+				}
 				this.prefixLookupPath = requestUri.substring(0, this.indexLookupPath);
 				if ("/".equals(lookupPath) && !"/".equals(requestUri)) {
 					String contextPath = pathHelper.getContextPath(this);
@@ -116,7 +116,7 @@ private void initLookupPath(ResourceUrlProvider urlProvider) {
 		public String resolveUrlPath(String url) {
 			if (this.resourceUrlProvider == null) {
 				logger.trace("ResourceUrlProvider not available via request attribute " +
-						"ResourceUrlProviderExposingInterceptor.RESOURCE_URL_PROVIDER_ATTR");
+						ResourceUrlProviderExposingInterceptor.RESOURCE_URL_PROVIDER_ATTR);
 				return null;
 			}
 			if (this.indexLookupPath != null && url.startsWith(this.prefixLookupPath)) {