Skip to content

Commit 9a618dc

Browse files
committed
Enforce ConditionalContentCachingResponseWrapper in ShallowEtagHeaderFilter
Closes gh-24976
1 parent 165a6f1 commit 9a618dc

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

spring-web/src/main/java/org/springframework/web/filter/ShallowEtagHeaderFilter.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ protected void doFilterInternal(HttpServletRequest request, HttpServletResponse
9999
throws ServletException, IOException {
100100

101101
HttpServletResponse responseToUse = response;
102-
if (!isAsyncDispatch(request) && !(response instanceof ContentCachingResponseWrapper)) {
102+
if (!isAsyncDispatch(request) && !(response instanceof ConditionalContentCachingResponseWrapper)) {
103103
responseToUse = new ConditionalContentCachingResponseWrapper(response, request);
104104
}
105105

@@ -111,10 +111,8 @@ protected void doFilterInternal(HttpServletRequest request, HttpServletResponse
111111
}
112112

113113
private void updateResponse(HttpServletRequest request, HttpServletResponse response) throws IOException {
114-
115-
ContentCachingResponseWrapper wrapper =
116-
WebUtils.getNativeResponse(response, ContentCachingResponseWrapper.class);
117-
114+
ConditionalContentCachingResponseWrapper wrapper =
115+
WebUtils.getNativeResponse(response, ConditionalContentCachingResponseWrapper.class);
118116
Assert.notNull(wrapper, "ContentCachingResponseWrapper not found");
119117
HttpServletResponse rawResponse = (HttpServletResponse) wrapper.getResponse();
120118

@@ -219,7 +217,6 @@ private static class ConditionalContentCachingResponseWrapper extends ContentCac
219217

220218
private final HttpServletRequest request;
221219

222-
223220
ConditionalContentCachingResponseWrapper(HttpServletResponse response, HttpServletRequest request) {
224221
super(response);
225222
this.request = request;

0 commit comments

Comments
 (0)