Skip to content

Commit aaeabc3

Browse files
stsypanovsbrannen
authored andcommitted
Simplify iteration over maps
Closes gh-23053
1 parent 5b04b04 commit aaeabc3

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

spring-jms/src/main/java/org/springframework/jms/support/SimpleJmsHeaderMapper.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,11 @@ public void fromHeaders(MessageHeaders headers, javax.jms.Message jmsMessage) {
9292
logger.debug("Failed to set JMSType - skipping", ex);
9393
}
9494
}
95-
Set<String> headerNames = headers.keySet();
96-
for (String headerName : headerNames) {
95+
Set<Map.Entry<String, Object>> entries = headers.entrySet();
96+
for (Map.Entry<String, Object> entry : entries) {
97+
String headerName = entry.getKey();
9798
if (StringUtils.hasText(headerName) && !headerName.startsWith(JmsHeaders.PREFIX)) {
98-
Object value = headers.get(headerName);
99+
Object value = entry.getValue();
99100
if (value != null && SUPPORTED_PROPERTY_TYPES.contains(value.getClass())) {
100101
try {
101102
String propertyName = this.fromHeaderName(headerName);

spring-test/src/main/java/org/springframework/test/context/cache/DefaultContextCache.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,9 @@ public void remove(MergedContextConfiguration key, @Nullable HierarchyMode hiera
180180
}
181181

182182
// Remove empty entries from the hierarchy map.
183-
for (MergedContextConfiguration currentKey : this.hierarchyMap.keySet()) {
184-
if (this.hierarchyMap.get(currentKey).isEmpty()) {
185-
this.hierarchyMap.remove(currentKey);
183+
for (Map.Entry<MergedContextConfiguration, Set<MergedContextConfiguration>> entry : this.hierarchyMap.entrySet()) {
184+
if (entry.getValue().isEmpty()) {
185+
this.hierarchyMap.remove(entry.getKey());
186186
}
187187
}
188188
}

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/SessionAttributesHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ public Map<String, Object> retrieveAttributes(WebSession session) {
113113
* @param attributes candidate attributes for session storage
114114
*/
115115
public void storeAttributes(WebSession session, Map<String, ?> attributes) {
116-
attributes.keySet().forEach(name -> {
117-
Object value = attributes.get(name);
116+
attributes.forEach((name, value) -> {
118117
if (value != null && isHandlerSessionAttribute(name, value.getClass())) {
119118
session.getAttributes().put(name, value);
120119
}

0 commit comments

Comments
 (0)