Skip to content

Commit cd12583

Browse files
authored
Use Integer.parseInt instead of Integer.valueOf for primitive int
Closes gh-25456
1 parent 24f9b1d commit cd12583

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

spring-aspects/src/test/java/org/springframework/cache/aspectj/AbstractCacheAnnotationTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,11 +416,11 @@ protected void testConditionalCacheUpdate(CacheableService<?> service) {
416416
Integer three = 3;
417417

418418
Cache cache = this.cm.getCache("testCache");
419-
assertThat((int) Integer.valueOf(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
419+
assertThat(Integer.parseInt(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
420420
assertThat(cache.get(one)).isNull();
421421

422-
assertThat((int) Integer.valueOf(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
423-
assertThat((int) Integer.valueOf(cache.get(three).get().toString())).isEqualTo((int) three);
422+
assertThat(Integer.parseInt(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
423+
assertThat(Integer.parseInt(cache.get(three).get().toString())).isEqualTo((int) three);
424424
}
425425

426426
protected void testMultiCache(CacheableService<?> service) {

spring-context/src/test/java/org/springframework/cache/config/EnableCachingIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ static class BeanConditionConfig {
195195

196196
@Bean
197197
public Bar bar() {
198-
return new Bar(Boolean.valueOf(env.getProperty("bar.enabled")));
198+
return new Bar(Boolean.parseBoolean(env.getProperty("bar.enabled")));
199199
}
200200

201201

spring-context/src/testFixtures/java/org/springframework/context/testfixture/cache/AbstractCacheAnnotationTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -411,11 +411,11 @@ protected void testConditionalCacheUpdate(CacheableService<?> service) {
411411
Integer three = 3;
412412

413413
Cache cache = this.cm.getCache("testCache");
414-
assertThat((int) Integer.valueOf(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
414+
assertThat(Integer.parseInt(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
415415
assertThat(cache.get(one)).isNull();
416416

417-
assertThat((int) Integer.valueOf(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
418-
assertThat((int) Integer.valueOf(cache.get(three).get().toString())).isEqualTo((int) three);
417+
assertThat(Integer.parseInt(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
418+
assertThat(Integer.parseInt(cache.get(three).get().toString())).isEqualTo((int) three);
419419
}
420420

421421
protected void testMultiCache(CacheableService<?> service) {

spring-core/src/test/java/org/springframework/util/xml/TransformerUtilsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void enableIndentingSunnyDay() throws Exception {
5555
void enableIndentingSunnyDayWithCustomKosherIndentAmount() throws Exception {
5656
final String indentAmountProperty = "10";
5757
Transformer transformer = new StubTransformer();
58-
TransformerUtils.enableIndenting(transformer, Integer.valueOf(indentAmountProperty));
58+
TransformerUtils.enableIndenting(transformer, Integer.parseInt(indentAmountProperty));
5959
String indent = transformer.getOutputProperty(OutputKeys.INDENT);
6060
assertThat(indent).isNotNull();
6161
assertThat(indent).isEqualTo("yes");

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/SockJsUrlInfoTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class SockJsUrlInfoTests {
3434
@Test
3535
public void serverId() throws Exception {
3636
SockJsUrlInfo info = new SockJsUrlInfo(new URI("https://example.com"));
37-
int serverId = Integer.valueOf(info.getServerId());
37+
int serverId = Integer.parseInt(info.getServerId());
3838
assertThat(serverId >= 0 && serverId < 1000).as("Invalid serverId: " + serverId).isTrue();
3939
}
4040

0 commit comments

Comments
 (0)