Skip to content

Commit e68bf01

Browse files
committed
Fix memory leak for ServerSentEventHttpMessageWriter
Issue: SPR-17419
1 parent f32e1bc commit e68bf01

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

spring-web/src/main/java/org/springframework/http/codec/ServerSentEventHttpMessageWriter.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
import org.springframework.core.codec.Hints;
3333
import org.springframework.core.io.buffer.DataBuffer;
3434
import org.springframework.core.io.buffer.DataBufferFactory;
35+
import org.springframework.core.io.buffer.DataBufferUtils;
36+
import org.springframework.core.io.buffer.PooledDataBuffer;
3537
import org.springframework.http.MediaType;
3638
import org.springframework.http.ReactiveHttpOutputMessage;
3739
import org.springframework.http.server.reactive.ServerHttpRequest;
@@ -144,7 +146,8 @@ private Flux<Publisher<DataBuffer>> encode(Publisher<?> input, ResolvableType el
144146

145147
return Flux.concat(encodeText(sb, mediaType, factory),
146148
encodeData(data, valueType, mediaType, factory, hints),
147-
encodeText("\n", mediaType, factory));
149+
encodeText("\n", mediaType, factory))
150+
.doOnDiscard(PooledDataBuffer.class, DataBufferUtils::release);
148151
});
149152
}
150153

0 commit comments

Comments
 (0)