Skip to content

Reference documentation for ContextClosedEvent is misleading #23436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akvone opened this issue Aug 8, 2019 · 3 comments
Closed

Reference documentation for ContextClosedEvent is misleading #23436

akvone opened this issue Aug 8, 2019 · 3 comments
Assignees
@sbrannen
Labels
type: documentation A documentation task
Milestone
5.2 RC2

Comments

@akvone
Copy link

akvone commented Aug 8, 2019 •
edited by sbrannen
Loading

Affects: <All Spring Framework versions>

The Spring Framework reference documentation for ContextClosedEvent states the following:

Published when the ApplicationContext is closed by using the close() method on the ConfigurableApplicationContext interface. Here, “closed” means that all singleton beans are destroyed. ...

It seems that such a definition may be misleading as soon as it sounds like event is triggered after beans destruction.

Actually AbstractApplicationContext#doClose defines the real execution order.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 8, 2019
@sbrannen sbrannen self-assigned this Aug 9, 2019
@sbrannen sbrannen added the type: documentation A documentation task label Aug 9, 2019
@sbrannen sbrannen added this to the 5.2 RC2 milestone Aug 9, 2019
@sbrannen
Copy link
Member

sbrannen commented Aug 9, 2019

@akvone, this has been addressed in 1925526.

Please let us know if that is clearer now.

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 9, 2019
@akvone
Copy link
Author

akvone commented Aug 9, 2019

Yes, it's definitely better.
Thanks

@sbrannen
Copy link
Member

sbrannen commented Aug 9, 2019

Yes, it's definitely better.
Thanks

Great! Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
type: documentation A documentation task
Projects
None yet
Milestone
5.2 RC2
Development

No branches or pull requests
3 participants
@sbrannen @spring-projects-issues @akvone