Skip to content

Fix Outcome KeyValues in HTTP observations #29232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Sep 30, 2022 · 0 comments
Closed

Fix Outcome KeyValues in HTTP observations #29232

bclozel opened this issue Sep 30, 2022 · 0 comments
Assignees
@bclozel
Labels
theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.0.0-RC1

Comments

@bclozel
Copy link
Member

bclozel commented Sep 30, 2022

Currently HTTP observations are using the org.springframework.http.HttpStatus.Series enum name to populate this information. Unfortunately this doesn't align with existing metrics instrumentation in Spring Boot, see Outcome.

We should introduce a shared HttpOutcome class that replicates the behavior and is used in the default conventions.
@bclozel bclozel added type: bug A general bug theme: observability An issue related to observability and tracing labels Sep 30, 2022
@bclozel bclozel added this to the 6.0.0-RC1 milestone Sep 30, 2022
@bclozel bclozel self-assigned this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@bclozel