Skip to content

Matching path pattern is not set in reactive ServerRequestObservationContext #29422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Nov 2, 2022 · 0 comments
Closed

Matching path pattern is not set in reactive ServerRequestObservationContext #29422

bclozel opened this issue Nov 2, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.0.0-RC3

Comments

@bclozel
Copy link
Member

bclozel commented Nov 2, 2022

The WebFlux instrumentation is not setting the o.s.web.reactive.HandlerMapping#BEST_MATCHING_PATTERN_ATTRIBUTE on the ServerRequestObservationContext. This means that the KeyValue extracted by the observation convention is always UNKNOWN.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing labels Nov 2, 2022
@bclozel bclozel added this to the 6.0.0-RC3 milestone Nov 2, 2022
@bclozel bclozel self-assigned this Nov 2, 2022
@bclozel bclozel closed this as completed in db79d1d Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC3
Development

No branches or pull requests
1 participant
@bclozel