Skip to content

Align server observation contextual names with OTel semantic conventions #29424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Nov 2, 2022 · 0 comments
Closed

Align server observation contextual names with OTel semantic conventions #29424

bclozel opened this issue Nov 2, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.0.0-RC3

Comments

@bclozel
Copy link
Member

bclozel commented Nov 2, 2022

Currently, observation contextual names (names actually used for traces) for HTTP server instrumentation use the format "http get". To better align with OpenTelemetry semantic conventions, we should use the path pattern as well if it is available in order to get "http get /resource/{name}".
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing labels Nov 2, 2022
@bclozel bclozel added this to the 6.0.0-RC3 milestone Nov 2, 2022
@bclozel bclozel self-assigned this Nov 2, 2022
@bclozel bclozel closed this as completed in a94b0e5 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC3
Development

No branches or pull requests
1 participant
@bclozel