Skip to content

Use latest version of sockjs-client in AbstractSockJsService #30848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Jul 10, 2023 · 0 comments
Closed

Use latest version of sockjs-client in AbstractSockJsService #30848

sdeleuze opened this issue Jul 10, 2023 · 0 comments
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: dependency-upgrade A dependency upgrade type: enhancement A general enhancement
Milestone
6.1.0-M2

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Jul 10, 2023 •
edited
Loading

We should update the url in AbstractSockJsService#clientLibraryUrl, currently hardcoded with 1.0.0 version, to use https://cdn.jsdelivr.net/npm/sockjs-client@1/dist/sockjs.min.js in order to use latest 1.x.y version. My tests with a basic sample seems to work as expected.
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jul 10, 2023
@sdeleuze sdeleuze added this to the 6.1.0-M2 milestone Jul 10, 2023
@sdeleuze sdeleuze self-assigned this Jul 10, 2023
@sdeleuze sdeleuze added the type: dependency-upgrade A dependency upgrade label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: dependency-upgrade A dependency upgrade type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

No branches or pull requests
1 participant
@sdeleuze