Skip to content

Various methods in SimpleJdbcInsert prevent method chaining #31177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbrannen opened this issue Sep 6, 2023 · 0 comments
Closed

Various methods in SimpleJdbcInsert prevent method chaining #31177

sbrannen opened this issue Sep 6, 2023 · 0 comments
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 6, 2023

The withoutTableColumnMetaDataAccess() and includeSynonymsForTableColumnMetaData() methods in SimpleJdbcInsert incorrectly declare a SimpleJdbcInsertOperations return type, which breaks method chaining when the instance is declared to be of type SimpleJdbcInsert.

They should benefit from covariant return types and declare SimpleJdbcInsert like the rest of the builder/configuration methods in SimpleJdbcInsert.

@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug labels Sep 6, 2023
@sbrannen sbrannen added this to the 6.1.0-RC1 milestone Sep 6, 2023
@sbrannen sbrannen self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant