Skip to content

Refine logic to release WebSocket ByteBuffer via Callback with Jetty 12 #31182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rstoyanchev opened this issue Sep 7, 2023 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

In Jetty 12, WebSocket handling methods that take ByteBuffer also take Callback and that needs to be called to release the buffer. On the WebFlux side we could use our DataBuffer abstraction to wrap and carry the Callback so it can be called when released. On the WebMvc side we don't have anything equivalent and will likely need to make a copy.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Sep 7, 2023
@rstoyanchev rstoyanchev added this to the 6.1.0-RC1 milestone Sep 7, 2023
@rstoyanchev rstoyanchev self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant