Skip to content

Use MergedAnnotations API directly in AnnotationBeanNameGenerator where possible #31203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Sep 11, 2023 · 0 comments
Closed

Use MergedAnnotations API directly in AnnotationBeanNameGenerator where possible #31203

sbrannen opened this issue Sep 11, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.1.0-M5

Comments

@sbrannen
Copy link
Member

AnnotationBeanNameGenerator was written before the introduction of the MergedAnnotations API and therefore heavily relies on the AnnotationMetadata abstraction and various helper methods for ASM compatibility.

However, recent work on determineBeanNameFromAnnotation(AnnotatedBeanDefinition) has made it apparent that we should use the MergedAnnotations API directly in AnnotationBeanNameGenerator where possible in order to avoid unnecessary, repeated iterations/streams over the same annotation metadata.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Sep 11, 2023
@sbrannen sbrannen added this to the 6.1.0-M5 milestone Sep 11, 2023
@sbrannen sbrannen self-assigned this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M5
Development

No branches or pull requests
1 participant
@sbrannen