Skip to content

Stop replacing existing Bean Override definitions with pseudo-definitions #33627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Oct 1, 2024 · 0 comments
Closed

Stop replacing existing Bean Override definitions with pseudo-definitions #33627

sbrannen opened this issue Oct 1, 2024 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.2.0-RC2

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 1, 2024

BeanOverrideBeanFactoryPostProcessor currently replaces existing bean definitions with "pseudo" bean definitions; however, that is unnecessary.

An existing BeanDefinition is suitable as-is and does not need to be replaced with a pseudo/fake definition.

The only time we need to register a new BeanDefinition is when we create a BeanDefinition for a nonexistent bean.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Oct 1, 2024
@sbrannen sbrannen added this to the 6.2.0-RC2 milestone Oct 1, 2024
@sbrannen sbrannen self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC2
Development

No branches or pull requests
1 participant
@sbrannen