Update testing docs for 4.0.0 with the updates in EmbeddedKafka #3822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soby Chacko <[email protected]>
artembilan
requested changes
Mar 25, 2025
| ---- | ||
|
|
||
| NOTE: The `EmbeddedKafkaKraftBroker` is not supported with JUnit4. | ||
| NOTE: The `EmbeddedKafkaRule` JUnit 4 rule has been removed in version 4.0. For JUnit 4, you should use the `EmbeddedKafkaKraftBroker` directly or migrate to JUnit 5 with the `@EmbeddedKafka` annotation. |
There was a problem hiding this comment.
One sentence per line: https://asciidoctor.org/docs/asciidoc-recommended-practices/
Suggested change
| NOTE: The `EmbeddedKafkaRule` JUnit 4 rule has been removed in version 4.0. For JUnit 4, you should use the `EmbeddedKafkaKraftBroker` directly or migrate to JUnit 5 with the `@EmbeddedKafka` annotation. | |
| NOTE: The `EmbeddedKafkaRule` JUnit 4 rule has been removed in version 4.0. | |
| For JUnit 4, you should use the `EmbeddedKafkaKraftBroker` directly or migrate to JUnit 5 with the `@EmbeddedKafka` annotation. |
| @@ -555,12 +528,12 @@ public class KafkaTemplateTests { | |||
| private static final String TEMPLATE_TOPIC = "templateTopic"; | |||
|
|
|||
| @ClassRule | |||
| public static EmbeddedKafkaRule embeddedKafka = new EmbeddedKafkaRule(1, true, TEMPLATE_TOPIC); | |||
| public static EmbeddedKafkaBroker embeddedKafka = new EmbeddedKafkaKraftBroker(1, 1, TEMPLATE_TOPIC); | |||
There was a problem hiding this comment.
I'm not sure that this is going to work since EmbeddedKafkaBroker is not a JUnit 4 Rule.
Pay attention to that @ClassRule on this property.
Perhaps @BeforeClass can be used instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.