Skip to content

Update javadoc in CommonOAuth2Provider #11490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Jul 12, 2022 · 0 comments
Closed

Update javadoc in CommonOAuth2Provider #11490

jgrandja opened this issue Jul 12, 2022 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@jgrandja
Copy link
Contributor

The original intent of CommonOAuth2Provider is to provide sensible defaults for the HttpSecurity.oauth2Login() flow when using a common provider, e.g. Google, Okta, Github and Facebook.

The javadoc should be enhanced to explicitly state that the defaults are meant to be used for ClientRegistration's configured for the oauth2Login() flow.
@jgrandja jgrandja added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jul 12, 2022
@jgrandja jgrandja self-assigned this Jul 12, 2022
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2022
@jgrandja jgrandja added this to the 6.0.0-M6 milestone Jul 12, 2022
@jgrandja jgrandja mentioned this issue Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
1 participant
@jgrandja